[PATCH] D34598: ScalarEvolution: Add URem support

[Alexandre Isoard via Phabricator via llvm-commits]

alexandre.isoard added inline comments.


================
Comment at: test/Analysis/ScalarEvolution/flattened.ll:1
+; RUN: opt < %s -scalar-evolution -analyze | tee /dev/fd/2 | FileCheck %s
+
----------------
efriedma wrote:
> "tee /dev/fd/2" is not portable.
> 
> Not sure why you need it, anyway; -analyze output goes to stdout.
Oops. That is a hack I use to print all of the stdout when the test case fail. (instead of the best matching line only)

I forgot to remove it.


================
Comment at: test/Analysis/ScalarEvolution/flattened.ll:14
+; CHECK: %a.ptr
+; CHECK: -->  {%a,+,1}<nw><%bb>
+	%val = load i8, i8* %a.ptr
----------------
efriedma wrote:
> CHECK-NEXT
Indeed. I add that in the next update.


https://reviews.llvm.org/D34598