[PATCH] D34764: Introduce FileEdit utility

[Zachary Turner via Phabricator via llvm-commits]

zturner added a comment.

In https://reviews.llvm.org/D34764#794038, @rnk wrote:

> Why `{!--`? It seems inconsistent with the usual LLVM thing of an all caps directive like CHECK:, RUN:, or a Unixy-EOF. Unbalanced braces will make tools like clang-format misbehave.


`clang-format` doesn't run against `.test` files anyway, so I don't think that should be a problem.  Also, all-caps directives are already reserved check prefixes, and overloading it here would not make the distinctino easily identifiable.  Am I looking at a check prefix or am I looking at a file directive?  I chose something that would stand out.  I could use a square brace instead of a curly brace, or even an angle bracket (although <!-- marks the beginning of an xml comment, not sure if that's a good or bad thing).


https://reviews.llvm.org/D34764