[PATCH] D34744: [DWARF] - Simplify HandleExpectedError implementation in DWARFDebugInfoTest

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 28 08:22:13 PDT 2017


grimar added inline comments.


================
Comment at: unittests/DebugInfo/DWARF/DWARFDebugInfoTest.cpp:102
   auto ExpectedDG = dwarfgen::Generator::create(Triple, Version);
   if (HandleExpectedError(ExpectedDG))
     return;
----------------
zturner wrote:
> I recently added some functions to llvm that server this purpose better.  I would suggest just deleting this function, and adding this:
> 
> ```
> #include "llvm/Testing/Support/Error.h"
> ...
> ASSERT_THAT_EXPECTED(ExpectedDG, Succeeded());
> ```
I'll take a look what ASSERT_THAT_EXPECTED do. If I got correctly from quivk look, that might be a better solution, really. Thanks !


https://reviews.llvm.org/D34744





More information about the llvm-commits mailing list