[PATCH] D34618: [LLD] Add basic 64-bit SPARC support
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 28 08:17:08 PDT 2017
ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: lld/ELF/SyntheticSections.cpp:1638-1639
+ HeaderSize(S) {
+ if (Config->EMachine == EM_SPARCV9)
+ this->Flags |= SHF_WRITE;
+}
----------------
kettenis wrote:
> ruiu wrote:
> > This is interesting. Can you describe why the .plt segment has to be writable on Sparc? I'd like to add a comment here about the background.
> I'll add a comment.
For the record: https://docs.oracle.com/cd/E19455-01/816-0559/chapter6-1236/index.html
https://reviews.llvm.org/D34618
More information about the llvm-commits
mailing list