[PATCH] D34744: [DWARF] - Simplify HandleExpectedError implementation in DWARFDebugInfoTest

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 28 08:08:06 PDT 2017


dblaikie added a comment.

I don't quite follow your description - this looks like it would print error messages, if the llvm::Error has a textual message (which not all do). I would expect the behavior should perhaps flip the other way - fix it so it does print a message even if the llvm::Error doesn't have a textual message itself? (I think llvm::Error has a more general tool for textual repreesntation, rather than just the message? Not sure)


https://reviews.llvm.org/D34744





More information about the llvm-commits mailing list