[PATCH] D33688: [Polly] Heap allocation for new arrays

Bonfante Nicolas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 28 05:39:48 PDT 2017


niosega updated this revision to Diff 104387.
niosega added a comment.

There are no valid reasons not to use getElemSizeInBytes instead of getPrimitiveSizeInBits. This solution (with getElemSizeInBytes) is much more cleaner.


https://reviews.llvm.org/D33688

Files:
  include/polly/CodeGen/IslNodeBuilder.h
  include/polly/ScopInfo.h
  lib/Analysis/ScopInfo.cpp
  lib/CodeGen/CodeGeneration.cpp
  lib/CodeGen/IslNodeBuilder.cpp
  lib/Exchange/JSONExporter.cpp
  test/Isl/CodeGen/MemAccess/create_arrays_heap.ll
  test/Isl/CodeGen/MemAccess/create_arrays_heap___%for.cond1.preheader---%for.end18.jscop
  test/Isl/CodeGen/MemAccess/create_arrays_heap___%for.cond1.preheader---%for.end18.jscop.transformed

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D33688.104387.patch
Type: text/x-patch
Size: 21243 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170628/e72b1ecf/attachment.bin>


More information about the llvm-commits mailing list