[lld] r306526 - [ELF] - Do not set st_size field of SHT_UNDEF symbols.

[George Rimar via llvm-commits]

Author: grimar
Date: Wed Jun 28 02:51:33 2017
New Revision: 306526

URL: http://llvm.org/viewvc/llvm-project?rev=306526&view=rev
Log:
[ELF] - Do not set st_size field of SHT_UNDEF symbols.

This fixes PR33598.

Size field for undefined symbols is not significant.
Setting it to fixed value, like zero, may be useful though.

For example when we have 2 DSO's, like in this PR, if lower level DSO may
change slightly (in part of some symbol's st_size)  and higher-level DSO is
rebuilt, then tools that monitoring checksum of high level DSO file can notice
it and trigger cascade of some other unnecessary actions. 
If we set st_size to zero, that can be avoided.

Differential revision: https://reviews.llvm.org/D34673

Added:
    lld/trunk/test/ELF/Inputs/dso-undef-size.s
    lld/trunk/test/ELF/dso-undef-size.s
Modified:
    lld/trunk/ELF/SyntheticSections.cpp

Modified: lld/trunk/ELF/SyntheticSections.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/SyntheticSections.cpp?rev=306526&r1=306525&r2=306526&view=diff
==============================================================================
--- lld/trunk/ELF/SyntheticSections.cpp (original)
+++ lld/trunk/ELF/SyntheticSections.cpp Wed Jun 28 02:51:33 2017
@@ -1376,7 +1376,6 @@ template <class ELFT> void SymbolTableSe
     }
 
     ESym->st_name = Ent.StrTabOffset;
-    ESym->st_size = Body->getSize<ELFT>();
 
     // Set a section index.
     if (const OutputSection *OutSec = Body->getOutputSection())
@@ -1386,6 +1385,14 @@ template <class ELFT> void SymbolTableSe
     else if (isa<DefinedCommon>(Body))
       ESym->st_shndx = SHN_COMMON;
 
+    // Copy symbol size if it is a defined symbol. st_size is not significant
+    // for undefined symbols, so whether copying it or not is up to us if that's
+    // the case. We'll leave it as zero because by not setting a value, we can
+    // get the exact same outputs for two sets of input files that differ only
+    // in undefined symbol size in DSOs.
+    if (ESym->st_shndx != SHN_UNDEF)
+      ESym->st_size = Body->getSize<ELFT>();
+
     // st_value is usually an address of a symbol, but that has a
     // special meaining for uninstantiated common symbols (this can
     // occur if -r is given).

Added: lld/trunk/test/ELF/Inputs/dso-undef-size.s
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/Inputs/dso-undef-size.s?rev=306526&view=auto
==============================================================================
--- lld/trunk/test/ELF/Inputs/dso-undef-size.s (added)
+++ lld/trunk/test/ELF/Inputs/dso-undef-size.s Wed Jun 28 02:51:33 2017
@@ -0,0 +1,4 @@
+.text
+.global foo
+.size foo, 4
+foo:

Added: lld/trunk/test/ELF/dso-undef-size.s
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/dso-undef-size.s?rev=306526&view=auto
==============================================================================
--- lld/trunk/test/ELF/dso-undef-size.s (added)
+++ lld/trunk/test/ELF/dso-undef-size.s Wed Jun 28 02:51:33 2017
@@ -0,0 +1,32 @@
+# REQUIRES: x86
+# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %S/Inputs/dso-undef-size.s -o %t1.o
+# RUN: ld.lld -shared %t1.o -o %t1.so
+# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t2.o
+# RUN: ld.lld -shared %t2.o %t1.so -o %t2.so
+# RUN: llvm-readobj -symbols -dyn-symbols %t2.so
+
+# CHECK:      Symbols [
+# CHECK-NEXT:   Symbol {
+# CHECK-NEXT:     Name: foo
+# CHECK-NEXT:     Value:
+# CHECK-NEXT:     Size: 0
+# CHECK-NEXT:     Binding:
+# CHECK-NEXT:     Type:
+# CHECK-NEXT:     Other:
+# CHECK-NEXT:     Section: Undefined
+# CHECK-NEXT:   }
+# CHECK-NEXT: ]
+# CHECK:      DynamicSymbols [
+# CHECK-NEXT:   Symbol {
+# CHECK-NEXT:     Name: foo
+# CHECK-NEXT:     Value:
+# CHECK-NEXT:     Size: 0
+# CHECK-NEXT:     Binding:
+# CHECK-NEXT:     Type:
+# CHECK-NEXT:     Other:
+# CHECK-NEXT:     Section: Undefined
+# CHECK-NEXT:   }
+# CHECK-NEXT: ]
+
+.text
+.global foo