[PATCH] D34605: [GlobalISel][X86] Support bitwise operations : G_AND, G_OR, G_XOR

[Ayman Musa via Phabricator via llvm-commits]

aymanmus accepted this revision.
aymanmus added a comment.
This revision is now accepted and ready to land.

LGTM. 
+ comment on a minor issue.



================
Comment at: test/CodeGen/X86/GlobalISel/and-scalar.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -mtriple=x86_64-linux-gnu -global-isel -verify-machineinstrs < %s -o - | FileCheck %s --check-prefix=ALL --check-prefix=X64
+
----------------
Add 32-bit run maybe?
remove --check-prefix as you check only ALL


================
Comment at: test/CodeGen/X86/GlobalISel/or-scalar.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -mtriple=x86_64-linux-gnu -global-isel -verify-machineinstrs < %s -o - | FileCheck %s --check-prefix=ALL --check-prefix=X64
+
----------------
same here.


================
Comment at: test/CodeGen/X86/GlobalISel/xor-scalar.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -mtriple=x86_64-linux-gnu -global-isel -verify-machineinstrs < %s -o - | FileCheck %s --check-prefix=ALL --check-prefix=X64
+
----------------
same here


https://reviews.llvm.org/D34605