[PATCH] D34309: [NewPM/Inliner] Customize threshold based on optlevel and sizelevel

[Easwaran Raman via Phabricator via llvm-commits]

eraman updated this revision to Diff 104333.
eraman added a comment.

Call getInlineParams in PassBuilder and pass the Params object to the existing Inliner constructor.


https://reviews.llvm.org/D34309

Files:
  lib/Passes/PassBuilder.cpp


Index: lib/Passes/PassBuilder.cpp
===================================================================
--- lib/Passes/PassBuilder.cpp
+++ lib/Passes/PassBuilder.cpp
@@ -558,8 +558,9 @@
   // Run the inliner first. The theory is that we are walking bottom-up and so
   // the callees have already been fully optimized, and we want to inline them
   // into the callers so that our optimizations can reflect that.
-  // FIXME; Customize the threshold based on optimization level.
-  MainCGPipeline.addPass(InlinerPass());
+  unsigned OptLevel = Level > O3 ? 2 : Level;
+  unsigned SizeLevel = Level > O3 ? Level - O3 : 0;
+  MainCGPipeline.addPass(InlinerPass(getInlineParams(OptLevel, SizeLevel)));
 
   // Now deduce any function attributes based in the current code.
   MainCGPipeline.addPass(PostOrderFunctionAttrsPass());
@@ -868,7 +869,10 @@
   // valuable as the inliner doesn't currently care whether it is inlining an
   // invoke or a call.
   // Run the inliner now.
-  MPM.addPass(createModuleToPostOrderCGSCCPassAdaptor(InlinerPass()));
+  unsigned OptLevel = Level > O3 ? 2 : Level;
+  unsigned SizeLevel = Level > O3 ? Level - O3 : 0;
+  MPM.addPass(createModuleToPostOrderCGSCCPassAdaptor(
+      InlinerPass(getInlineParams(OptLevel, SizeLevel))));
 
   // Optimize globals again after we ran the inliner.
   MPM.addPass(GlobalOptPass());


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D34309.104333.patch
Type: text/x-patch
Size: 1353 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170628/49053797/attachment.bin>