[PATCH] D34359: [DWARF] Verification of the validity of the hash data offset and hash data DIEs in the the .apple_names section.

[Frederic Riss via Phabricator via llvm-commits]

friss accepted this revision.
friss added a comment.
This revision is now accepted and ready to land.

This LGTM. Few nitpicks you might wanna address before committing:



================
Comment at: lib/DebugInfo/DWARF/DWARFAcceleratorTable.cpp:84
+    DWARFFormValue FormValue(Atom.second);
+    if (isSupportedForm(FormValue)) {
+      FormValue.extractValue(AccelSection, &HashDataOffset, NULL);
----------------
I think you can do that test only once for the whole table instead of at each iteration.


================
Comment at: test/tools/llvm-dwarfdump/X86/apple_names.test:1-5
+RUN: llvm-dwarfdump -verify %p/../../../DebugInfo/Inputs/dwarfdump-objc.x86_64.o \
+RUN:     | FileCheck %s
+
+CHECK: Verifying .apple_names
+CHECK-NEXT: No errors.
----------------
No big deal, but I would just add these checks to the test/DebugInfo/dwarfdump-accel.test test.


https://reviews.llvm.org/D34359