[PATCH] D31834: Remove unnecessary bitvector clear
Xin Tong via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 27 17:17:14 PDT 2017
trentxintong added a comment.
In https://reviews.llvm.org/D31834#793133, @qcolombet wrote:
> Although this is correct, I don't think that is useful. We could add functionalities to this pass that would make use of that information (e.g., a dump method that we could call from the debugger anywhere in the program) and having the state being clean, seems like a good thing to me.
>
> Unless I am mistaken, this shouldn't have any performance implication, so the clean state seems worth it.
> Am I missing something?
I agree that the performance implication is small. I am not sure where you want to check for whether the state is clean or not.
https://reviews.llvm.org/D31834
More information about the llvm-commits
mailing list