[PATCH] D34713: [TableGen] Improve Debug Output for --debug-only=subtarget-emitter NFCI

Joel Jones via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 27 17:00:10 PDT 2017


joelkevinjones added inline comments.


================
Comment at: utils/TableGen/CodeGenSchedule.cpp:548
 
+  dbgs() << "\n+++ ITINERARIES and/or MACHINE MODELS (collectSchedClasses) +++\n";
   for (const CodeGenInstruction *Inst : Target.getInstructionsByEnumValue()) {
----------------
MatzeB wrote:
> Add DEBUG()
Not needed here, as everything after the "if" statement on line 545 to the end of the method only executes if in DEBUG mode. Not necessarily the style I would use, but it does follow what the rest of the file does.


Repository:
  rL LLVM

https://reviews.llvm.org/D34713





More information about the llvm-commits mailing list