[PATCH] D34720: Hook the sample PGO machinery in the new PM

[Dehao Chen via llvm-commits]

On Tue, Jun 27, 2017 at 4:00 PM, Xinliang David Li <davidxl at google.com> wrote:
>
>
> On Tue, Jun 27, 2017 at 3:54 PM, Dehao Chen via Phabricator
> <reviews at reviews.llvm.org> wrote:
>>
>> danielcdh added a comment.
>>
>> In https://reviews.llvm.org/D34720#792993, @davidxl wrote:
>>
>> > One or more integration test (using clang driver with new PM) is
>> > probably needed.
>>
>>
>> The test is added in the clang side: https://reviews.llvm.org/D34721
>>
>
>
> Is that test good enough to catch most of the expected bahavior with the
> pipeline? (e.g,  hot callsite from hot inline instance chain)? This will
> help prevent accidental pipeline change that affects autoFDO.  Probably in a
> different patch.

An enhanced integration test is proposed in https://reviews.llvm.org/D34725

Thanks,
Dehao

>
> David
>>
>>
>> https://reviews.llvm.org/D34720
>>
>>
>>
>