[PATCH] D34705: [COFF, ARM64] Add support for Windows ARM64 COFF format

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.

I'm no expert of this code, but as Saleem has already LGTMed, I think you can go ahead to submit.



================
Comment at: lib/Object/COFFObjectFile.cpp:1221
+    switch (Reloc->Type) {
+    LLVM_COFF_SWITCH_RELOC_TYPE_NAME(IMAGE_REL_ARM64_ABSOLUTE);
+    LLVM_COFF_SWITCH_RELOC_TYPE_NAME(IMAGE_REL_ARM64_ADDR32);
----------------
Sort alphabetically.


================
Comment at: lib/Target/AArch64/MCTargetDesc/AArch64WinCOFFStreamer.cpp:22
+                        raw_pwrite_stream &OS)
+      : MCWinCOFFStreamer(C, AB, CE, OS) {}
+};
----------------
Is this the correct indentation? Please use clang-format-diff on your patch so that we don't need to worry about formatting.


https://reviews.llvm.org/D34705