[PATCH] D33974: Object: Teach irsymtab::read() to try to use the irsymtab that we wrote to disk.

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 27 16:31:02 PDT 2017


tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/test/Object/X86/irsymtab.ll:8
+; Different producer, requires upgrade.
+; RUN: env LLVM_OVERRIDE_PRODUCER=consumer llvm-lto2 dump-symtab %t | FileCheck --check-prefix=SYMTAB %s
+
----------------
pcc wrote:
> tejohnson wrote:
> > Wouldn't the producer string in this second case be "consumer" since it would have been upgraded?
> The idea is that `llvm-lto2` prints the producer string from before the upgrade. That seems more useful than printing the producer from after an upgrade since that's basically equivalent to "print the current producer string".
Ok true


https://reviews.llvm.org/D33974





More information about the llvm-commits mailing list