[PATCH] D34709: [Profile] Improve profile dumping with merging

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a comment.

This sounds like a great idea.



================
Comment at: lib/profile/InstrProfilingFile.c:228
   }
-  fseek(ProfileFile, 0L, SEEK_SET);
   return ProfileFile;
 }
----------------
Can you remove the extra fseek in a separate commit?


================
Comment at: lib/profile/InstrProfilingWriter.c:281
+      {SkipNameDataWrite ? NULL : NamesBegin, sizeof(uint8_t), NamesSize},
+      {Zeroes, sizeof(uint8_t), Padding}};
   if (Writer->Write(Writer, IOVec, sizeof(IOVec) / sizeof(*IOVec)))
----------------
If we aren't writing the name data, can't we also avoid writing __llvm_profile_data, and the padding?


https://reviews.llvm.org/D34709