[PATCH] D34705: [COFF, ARM64] Add support for Windows ARM64 COFF format

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: lib/Target/AArch64/AArch64MCInstLower.cpp:168
     return lowerSymbolOperandDarwin(MO, Sym);
+  else if (Printer.TM.getTargetTriple().isOSBinFormatCOFF())
+    return lowerSymbolOperandCOFF(MO, Sym);
----------------
Remove `else` as the last `if` ends with `return`.


================
Comment at: lib/Target/AArch64/AArch64MCInstLower.h:46
+  MCOperand lowerSymbolOperandCOFF(const MachineOperand &MO,
+                                  MCSymbol *Sym) const;
   MCOperand LowerSymbolOperand(const MachineOperand &MO, MCSymbol *Sym) const;
----------------
Fix indentation


================
Comment at: lib/Target/AArch64/AArch64TargetMachine.cpp:170
     return llvm::make_unique<AArch64_MachoTargetObjectFile>();
+  else if (TT.isOSBinFormatCOFF())
+    return llvm::make_unique<AArch64_COFFTargetObjectFile>();
----------------
Ditto


================
Comment at: lib/Target/AArch64/MCTargetDesc/AArch64WinCOFFObjectWriter.cpp:50-51
+                                         const MCAsmBackend &MAB) const {
+  switch (static_cast<unsigned>(Fixup.getKind())) {
+    default: {
+      const MCFixupKindInfo &Info = MAB.getFixupKindInfo(Fixup.getKind());
----------------
For now, remove `switch` and `default`.


Repository:
  rL LLVM

https://reviews.llvm.org/D34705