[PATCH] D34657: [WebAssembly] Add data size and alignment to linking section

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added inline comments.


================
Comment at: lib/MC/WasmObjectWriter.cpp:932
   SmallVector<char, 0> DataBytes;
+  uint32_t DataAlignment = 0;
   uint32_t StackPointerGlobal = 0;
----------------
dschuff wrote:
> Maybe we should make the min data alignment be 1? Should we have 0 or missing alignment be some default? Maybe the default should just be the min too. Or we could have the min be 4; in general I guess we'd probably want numbers to have min alignment of 4 (which we can also set in the compiler), but for strings maybe we don't care and can let it be less?
Changed the default to 1 for now.  We can revisit this when I update Linking.md


https://reviews.llvm.org/D34657