[PATCH] D34644: Only test sanitizers that are built when COMPILER_RT_SANITIZERS_TO_BUILD is used

Francis Ricci via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 27 11:06:56 PDT 2017


fjricci marked an inline comment as done.
fjricci added a comment.

As far as I'm aware, the feature exists both to save time building and testing sanitizers you don't need, and to get around differing build requirements across the sanitizers (it's possible, especially when cross-compiling, that some sanitizers build in a given configuration and others do not).



================
Comment at: test/CMakeLists.txt:66
+    compiler_rt_test_runtime(lsan)
+    compiler_rt_test_runtime(ubsan cfi)
+    compiler_rt_test_runtime(sanitizer_common)
----------------
pcc wrote:
> I guess if you want this to be controlled by `COMPILER_RT_SANITIZERS_TO_BUILD` it would need to be calling `compiler_rt_test_sanitizer`.
The components built as part of the common runtime aren't controlled by `COMPILER_RT_SANITIZERS_TO_BUILD` (lsan, ubsan, sanitizer_common, interception, etc).


https://reviews.llvm.org/D34644





More information about the llvm-commits mailing list