[PATCH] D34359: [DWARF] Verification of the validity of the hash data offset and hash data DIEs in the the .apple_names section.

[Spyridoula Gravani via Phabricator via llvm-commits]

sgravani updated this revision to Diff 104213.
sgravani marked 5 inline comments as done.
sgravani added a comment.

Added isSupportedForm() function in DWARFFormValue class that will help us get more detailed error messages 
when reading the Atoms in apple_names (and in future any accelerator table) during verification.

Addressed reviewer's comments.


https://reviews.llvm.org/D34359

Files:
  include/llvm/BinaryFormat/Dwarf.h
  include/llvm/DebugInfo/DWARF/DWARFAcceleratorTable.h
  include/llvm/DebugInfo/DWARF/DWARFFormValue.h
  lib/DebugInfo/DWARF/DWARFAcceleratorTable.cpp
  lib/DebugInfo/DWARF/DWARFFormValue.cpp
  lib/DebugInfo/DWARF/DWARFVerifier.cpp
  test/tools/llvm-dwarfdump/X86/apple_names_verify_atoms.s
  test/tools/llvm-dwarfdump/X86/apple_names_verify_buckets.s
  test/tools/llvm-dwarfdump/X86/apple_names_verify_data.s
  test/tools/llvm-dwarfdump/X86/apple_names_verify_form.s
  test/tools/llvm-dwarfdump/X86/no_apple_names_verify_buckets.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D34359.104213.patch
Type: text/x-patch
Size: 33221 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170627/9ca4747d/attachment-0001.bin>