[PATCH] D34698: [AArch64] Inline callee if its target-features are a subset of the caller

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 27 10:39:51 PDT 2017


fhahn added a comment.

The test checks that the call to `bar` at line 24 in `qux` is not inlined, because `bar` has `+crypto` as additional target-feature. I think that should fail if we replace the function with `return true`.

Agreed that we have to keep the `areInlineCompatible` function in mind when adding new attributes that require stricter rules. In the patch for ARM (https://reviews.llvm.org/D34697) I've added a special check for thumb-mode.


https://reviews.llvm.org/D34698





More information about the llvm-commits mailing list