[PATCH] D33964: [LLVM][llvm-objcopy] Added basic plumbing to get things started
Jake Ehrlich via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 27 10:26:21 PDT 2017
jakehehrlich updated this revision to Diff 104203.
jakehehrlich added a comment.
I made the changes recommended by jhenderson. I particularly liked the sorting by offsets recommendation. I also simplified the finalize method in segment. Before it was deciding segment FileSize which it shouldn't and it was using a complicated method to find the minimum when it didn't need to.
https://reviews.llvm.org/D33964
Files:
test/tools/llvm-objcopy/basic-copy.test
tools/LLVMBuild.txt
tools/llvm-objcopy/CMakeLists.txt
tools/llvm-objcopy/LLVMBuild.txt
tools/llvm-objcopy/Object.cpp
tools/llvm-objcopy/Object.h
tools/llvm-objcopy/llvm-objcopy.cpp
tools/llvm-objcopy/llvm-objcopy.h
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D33964.104203.patch
Type: text/x-patch
Size: 20108 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170627/701a4432/attachment.bin>
More information about the llvm-commits
mailing list