[PATCH] D34658: [WebAssembly] Add support for printing relocations with llvm-objdump

Derek Schuff via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 27 10:11:07 PDT 2017


dschuff accepted this revision.
dschuff added a comment.
This revision is now accepted and ready to land.

otherwise LGTM



================
Comment at: tools/llvm-objdump/llvm-objdump.cpp:1085
     return getRelocationValueString(ELF, Rel, Result);
-  if (auto *COFF = dyn_cast<COFFObjectFile>(Obj))
+  else if (auto *COFF = dyn_cast<COFFObjectFile>(Obj))
     return getRelocationValueString(COFF, Rel, Result);
----------------
LLVM style is "don't use else after return" (http://llvm.org/docs/CodingStandards.html#don-t-use-else-after-a-return)


https://reviews.llvm.org/D34658





More information about the llvm-commits mailing list