[PATCH] D34694: llvm-profdata: Indirect infrequently used fields to reduce memory usage

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 27 08:52:47 PDT 2017


dblaikie added a comment.

Open questions:

Is this relatively low incidence of IndirectCall and MemOP collections representative, or is it likely to be more common in the future/in other use cases? (I haven't really looked at the code/what these mean in any great detail at all)

The copyability of InstrProfRecord might be able to be avoided with more work - there were certainly a bunch of cases where they didn't need to be copied that I found before I hit a more difficult one that seemed like more work than was worth it for the prototype of this change at least, but happy to go back to that if it seems worthwhile.

If InstrProfWriter's going to need to move away from InstrProfRecord anyway (to avoid the Name/Hash/Error values) this change may be a dead end not worth committing (since it'd change the data structure, only to not end up using the data structure in this codepath anyway).


https://reviews.llvm.org/D34694





More information about the llvm-commits mailing list