[PATCH] D34571: [DAGCombine] Improve handling of insert_subvector of bitcast values

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:15473
 
+  // If we N0 is also an insert_subvector and we've the only use fix it first.
+  if (N0.hasOneUse() && N0->getOpcode() == ISD::INSERT_SUBVECTOR)
----------------
"If we N0"?


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:15485
+  // If inserting a bitcast values into an undef vector, w/ same num
+  // elements, we can just use the bitcast input of the extract
+  if (N0.isUndef() && N1.getOpcode() == ISD::BITCAST &&
----------------
Period on the end of the comment.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:15494
+
+  // If Both N1 and N2 are bit cast values on which insert_subvector
+  // makes sense, pull bitcast through the insert.
----------------
No space between "bit" and "cast" to match the comment above?


https://reviews.llvm.org/D34571