[PATCH] D33972: Object: Add version and producer fields to the irsymtab header. NFCI.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: llvm/include/llvm/Object/IRSymtab.h:137
+  /// in symbol table format, symbol enumeration order and so on.
+  Str Producer;
+
----------------
tejohnson wrote:
> Thinking it would be good to print these when dumping the symtab. That would help on one of the tests added on D33974 (I'll note it there).
Yes, maybe. It would mean that `dump-symtab` would have to have its own copy of the code that reads the header because right now it always uses (via a few layers of indirection) `irsymtab::readBitcode` which will always upgrade mismatching versions. I could add that in D33974 I suppose.


https://reviews.llvm.org/D33972