[PATCH] D34637: [libunwind] Add _LIBUNWIND_DISABLE_VISIBILITY_ANNOTATIONS

[Tom Anderson via Phabricator via llvm-commits]

thomasanderson added inline comments.


================
Comment at: src/config.h:47
 
-// FIXME: these macros are not correct for COFF targets
-#define _LIBUNWIND_EXPORT __attribute__((visibility("default")))
-#define _LIBUNWIND_HIDDEN __attribute__((visibility("hidden")))
+#if defined(_LIBUNWIND_DISABLE_VISIBILITY_ANNOTATIONS)
+  #define _LIBUNWIND_EXPORT
----------------
compnerd wrote:
> If the intent is to prevent the symbols from being exported, then hidden visibility is still desirable.  I think that having something like a check for a static build makes more sense rather than just disabling the visibility annotations.
This is what libc++ and libc++abi do already.  Search for _LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS and _LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS


https://reviews.llvm.org/D34637