[PATCH] D34595: Made OPT_meabi value handling simpler
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 26 13:31:56 PDT 2017
ruiu added a comment.
Nice find!
Looks like the original intention of this code is to convert a string to an enum value and then initialize Opts.EABIVersion with the enum. So I wonder if we should change the type of Opts.EABIVersion (which is defined in clang/include/clang/Basic/TargetOptions.h) from std::string to llvm::EABI and keep the StringSwitch.
https://reviews.llvm.org/D34595
More information about the llvm-commits
mailing list