[PATCH] D34642: Restore original intent of memset instcombine test

Daniel Neilson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 26 13:26:13 PDT 2017


dneilson added inline comments.


================
Comment at: test/Transforms/InstCombine/memset.ll:14
   %target_p = getelementptr [1024 x i8], [1024 x i8]* %target, i32 0, i32 0
   call void @llvm.memset.p0i8.i32(i8* %target_p, i8 1, i32 0, i32 1, i1 false)
   call void @llvm.memset.p0i8.i32(i8* %target_p, i8 1, i32 1, i32 1, i1 false)
----------------
efriedma wrote:
> Your CHECK lines aren't checking that this memset was eliminated.  (Maybe you can do something with CHECK-NEXT?)
Good point. CHECK-NOT, perhaps?


https://reviews.llvm.org/D34642





More information about the llvm-commits mailing list