[PATCH] D34473: [LV] Changing the interface of ValueMap

Michael Kuperstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 26 08:42:52 PDT 2017


mkuper accepted this revision.
mkuper added a comment.
This revision is now accepted and ready to land.

LGTM, but please wait for Matt.



================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:699
+        for (unsigned Part = 0; Part < UF; ++Part)
+          Entry[Part].resize(VF);
+        ScalarMapStorage[Key] = Entry;
----------------
Ayal wrote:
> mssimpso wrote:
> > `Entry[Part].resize(VF)` null initializes the values, right?
> Ah, sure, if we remember to do `Entry[Part].resize(VF, nullptr)` ... Good catch, Thanks!
I'm pretty sure it null-initializes implicitly, but explicit is always good. :-)


https://reviews.llvm.org/D34473





More information about the llvm-commits mailing list