[PATCH] D33999: Refine the condition for when to use CALL16 vs a GOT displacement.

[Simon Dardis via Phabricator via llvm-commits]

sdardis accepted this revision.
sdardis added a comment.
This revision is now accepted and ready to land.

LGTM apart from formatting. Do you need me to commit this for you?



================
Comment at: lib/Target/Mips/AsmParser/MipsAsmParser.cpp:2868-2872
+        Res.getConstant() == 0 && !(Res.getSymA()->getSymbol().isInSection() ||
+        Res.getSymA()->getSymbol().isTemporary() ||
+        (Res.getSymA()->getSymbol().isELF() &&
+        cast<MCSymbolELF>(Res.getSymA()->getSymbol()).getBinding() ==
+        ELF::STB_LOCAL))) {
----------------
This hunk is not clang-formatted. It should be:

    if ((DstReg == Mips::T9 || DstReg == Mips::T9_64) && !UseSrcReg &&                                                 
        Res.getConstant() == 0 &&
        !(Res.getSymA()->getSymbol().isInSection() ||                                                                  
          Res.getSymA()->getSymbol().isTemporary() ||                                                                  
          (Res.getSymA()->getSymbol().isELF() &&
           cast<MCSymbolELF>(Res.getSymA()->getSymbol()).getBinding() ==                                               
               ELF::STB_LOCAL))) {


https://reviews.llvm.org/D33999