[PATCH] D34396: Adding code padding for performance stability - first policy (BranchesWithSameTargetAvoidancePolicy)

[Omer Paparo Bivas via Phabricator via llvm-commits]

opaparo added inline comments.


================
Comment at: lib/Target/X86/MCTargetDesc/LLVMBuild.txt:22
 parent = X86
-required_libraries = MC MCDisassembler Object Support X86AsmPrinter X86Info
+required_libraries = CodeGen Core MC MCDisassembler Object Support Target X86AsmPrinter X86Info
 add_to_library_groups = X86
----------------
craig.topper wrote:
> MC layer is not allowed to depend on CodeGen, Core or Target by explicit design requirements. llvm-mc does not want to link those libraries in.
> 
> What components do you need from these libraries?
Thanks for the heads up. I'm using MachineBasicBlock, MachineFunction, MachineLoopInfo and TargetMachine in X86MCCodePadder for code padding related decisions.

I understand now why this is problematic and I am looking for ways to remove those dependencies.
By the way, are llvm component dependencies documented anywhere? Is there some sort of document listing them and stating what's allowed and what's not?


Repository:
  rL LLVM

https://reviews.llvm.org/D34396