[PATCH] D33186: [InstCombine] Canonicalize clamp of float types to minmax in fast mode.

[Andrei Elovikov via Phabricator via llvm-commits]

a.elovikov marked 4 inline comments as done.
a.elovikov added inline comments.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:3957
+
+  // Assume success now. If there's no match, callers should not use these anyway.
+  LHS = TrueVal;
----------------
efriedma wrote:
> "Assume success" is a little confusing... maybe something more like "Return the LHS and RHS early".
This is copy-paste from the integer case in function `matchMinMax` below. Do you want me to change both places? Also, in the integer case the intent was pretty clear for me with no confusion.


https://reviews.llvm.org/D33186