[PATCH] D34285: [SROA] Be smarter when copying metadata to retyped loads

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 25 23:55:11 PDT 2017


chandlerc added a comment.

I landed some simpler refactorings in r306267 that should be enough to implement this.

However, I noticed that SROA actually assert fails on your test case without this patch, and in a seemingly unrelated manner. I want to understand this before landing your patch (or equivalent using different API). That said, feel free to update your patch based on r306267 or I will when I finish debugging (or if you can debug the assert, let me know).

I definitely want to get this unblocked for Rust, but it seems pretty scary to paper over an assert failure. Anyways, will try to keep this moving.


https://reviews.llvm.org/D34285





More information about the llvm-commits mailing list