[PATCH] D27701: [lit] Fix discovery test on Windows

Brian Gesiak via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 24 20:52:20 PDT 2017


modocache added a comment.

@delcypher Sorry for the //incredibly// late reply to your comment here. You mentioned:

> I think it would be better to get all the tests passing so we can run under Windows so we can turn on the build bots and then try to figure out how to improve the tests. If you feel the same way and are happy to look into fixing up the tests after we get the build bots up then I'll be happy to approve this patch and the others that get the tests working under Windows.

What would you think of, instead of fixing all of the Windows tests first, we mark them as `XFAIL: windows`? That way, we could un-revert https://reviews.llvm.org/rL257221, which makes it much easier to run the lit tests in the first place, and then we can take our time fixing the Windows tests. This would be my preferred order, since debugging some of these WIndows test failures is a pain.

In any case, your reviews certainly weren't holding back progress! On the contrary, I'm sorry I got sidetracked. I'd love to add a `check-lit` CMake target, and if getting the tests to pass on Windows is a prerequisite for that, I can devote some time to doing so in the next few weeks.


https://reviews.llvm.org/D27701





More information about the llvm-commits mailing list