[PATCH] D34311: [InstCombine] Don't replace allocas with smaller globals

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 23 17:55:11 PDT 2017


vitalybuka added inline comments.


================
Comment at: lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp:180
+    return false;
+  return isDereferenceableAndAlignedPointer(V, 1, APInt(64, AllocaSize), DL);
+}
----------------
efriedma wrote:
> Doesn't the alignment here need to be the alignment of the alloca, rather than "1"?
I'd expect it's not important as alignment of the source is not less than alloca.


https://reviews.llvm.org/D34311





More information about the llvm-commits mailing list