[PATCH] D34521: Remove /nologo from windows build

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 23 14:07:16 PDT 2017


probinson added a comment.

I am mildly curious how much noise this adds to a build log.



================
Comment at: cmake/modules/AddLLVM.cmake:675
   endif()
-  
+
   if( EXCLUDE_FROM_ALL )
----------------
Usually whitespace/formatting fixes are done separately.


================
Comment at: cmake/modules/AddLLVM.cmake:1331
   # and replace it with CMAKE_CFG_INTDIR. This allows the build step to be type
-  # agnostic again. 
+  # agnostic again.
   if(NOT ARG_OUTPUT_DIR)
----------------
Usually whitespace/formatting fixes are done separately.


https://reviews.llvm.org/D34521





More information about the llvm-commits mailing list