[PATCH] D34538: Handle ConstantExpr correctly in SelectionDAGBuilder

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: test/CodeGen/Generic/pr33094.ll:2
+; RUN: llc < %s
+
+%A = type {}
----------------
RKSimon wrote:
> efriedma wrote:
> > Needs a comment describing what it's testing.
> > 
> > Writing tests without any CHECK lines is usually a bad idea, because they tend to be very easy to break, but I'm not sure what we would want to check for here, exactly, so I guess this is okay.
> Shouldn't this at least include a REQUIRES: asserts?
Why would we want "REQUIRES: asserts"?  The test isn't checking debug output, or anything like that.


https://reviews.llvm.org/D34538