[PATCH] D34570: [DWARF] NFC: Collect info needed by DWARFFormValue into a helper

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 23 13:40:13 PDT 2017


probinson added a comment.

As a follow-up, I was thinking that the DwarfFormat enum could be given a 1-byte base type (given that it has only two values), which would make DWARFFormParams only 4 bytes, which would make it reasonable to pass around by value instead of by reference.


https://reviews.llvm.org/D34570





More information about the llvm-commits mailing list