[PATCH] D33541: Change the LNT command line parser to click

[Chris Matthews via Phabricator via llvm-commits]

cmatthews requested changes to this revision.
cmatthews added a comment.
This revision now requires changes to proceed.

This looks like a great idea to me.  I am very happy to modernize to click. Only nit: code and doc comments should always use full sentences.   Please fix comment, otherwise looks good!



================
Comment at: lnt/tests/builtintest.py:25
 
+    def _error(self, msg):
+        """This simulate the output provided by OptionParser.error"""
----------------
The name _fatal would match more the error logging in the rest of LNT.  We use error for non-exiting, and fatal for exit on the spot issues.


https://reviews.llvm.org/D33541