[llvm] r306147 - [opt-viewer] Remove positional arg checks (NFC)

Brian Gesiak via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 23 13:06:34 PDT 2017


Author: modocache
Date: Fri Jun 23 15:06:34 2017
New Revision: 306147

URL: http://llvm.org/viewvc/llvm-project?rev=306147&view=rev
Log:
[opt-viewer] Remove positional arg checks (NFC)

Summary:
opt-stats.py and opt-viewer.py's argument parsers both take a positional
argument 'yaml_files'. Positional arguments in Python's argparse module are
required by default, so the subsequent checks for `len(args.yaml_files) == 0`
are unnecessary -- if the length was zero, then the call to
`parser.parse_args()` would have thrown an error already.

Because there is no way for `len(args.yaml_files)` to be zero at these
points, removing the code is NFC.

Reviewers: anemet, davidxl

Reviewed By: anemet

Subscribers: llvm-commits, fhahn

Differential Revision: https://reviews.llvm.org/D34567

Modified:
    llvm/trunk/utils/opt-viewer/opt-stats.py
    llvm/trunk/utils/opt-viewer/opt-viewer.py

Modified: llvm/trunk/utils/opt-viewer/opt-stats.py
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/opt-viewer/opt-stats.py?rev=306147&r1=306146&r2=306147&view=diff
==============================================================================
--- llvm/trunk/utils/opt-viewer/opt-stats.py (original)
+++ llvm/trunk/utils/opt-viewer/opt-stats.py Fri Jun 23 15:06:34 2017
@@ -24,10 +24,6 @@ if __name__ == '__main__':
         help='Max job count (defaults to %(default)s, the current CPU count)')
     args = parser.parse_args()
 
-    if len(args.yaml_files) == 0:
-        parser.print_help()
-        sys.exit(1)
-
     if args.jobs == 1:
         pmap = map
     else:

Modified: llvm/trunk/utils/opt-viewer/opt-viewer.py
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/opt-viewer/opt-viewer.py?rev=306147&r1=306146&r2=306147&view=diff
==============================================================================
--- llvm/trunk/utils/opt-viewer/opt-viewer.py (original)
+++ llvm/trunk/utils/opt-viewer/opt-viewer.py Fri Jun 23 15:06:34 2017
@@ -216,10 +216,6 @@ if __name__ == '__main__':
         help='set source directory')
     args = parser.parse_args()
 
-    if len(args.yaml_files) == 0:
-        parser.print_help()
-        sys.exit(1)
-
     if args.jobs == 1:
         pmap = map
     else:




More information about the llvm-commits mailing list