[PATCH] D34538: Handle ConstantExpr correctly in SelectionDAGBuilder

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 23 12:53:37 PDT 2017


efriedma added a comment.

I'll think about the SelectionDAGBuilder::visit issue myself, and maybe come up with a followup patch.



================
Comment at: test/CodeGen/Generic/pr33094.ll:2
+; RUN: llc < %s
+
+%A = type {}
----------------
Needs a comment describing what it's testing.

Writing tests without any CHECK lines is usually a bad idea, because they tend to be very easy to break, but I'm not sure what we would want to check for here, exactly, so I guess this is okay.


https://reviews.llvm.org/D34538





More information about the llvm-commits mailing list