[PATCH] D34525: Replace trivial use of external rc.exe by writing our own .res file.

[Eric Beckmann via Phabricator via llvm-commits]

ecbeckmann added inline comments.


================
Comment at: llvm/include/llvm/Object/WindowsResource.h:70
+  void setType(uint16_t ID) {
+    TypeFlag = 0xffff;
+    TypeID = ID;
----------------
ruiu wrote:
> Instead of defining setType and setName, you can just set TypeFlag and NameID to 0xffff in writeResEntryHeader, no?
I think it would be better if this level were abstracted away from the user class.  After all, it is a detail of the Type and Name fields that the most significant bytes are //always// set to high when number IDs are used.  This is an implementation detail about the .res spec that should be hidden.


https://reviews.llvm.org/D34525