[PATCH] D34204: [LLD][LinkerScript] Allow non-alloc sections to be assigned to segments.
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 23 09:42:13 PDT 2017
ruiu added a comment.
This is probably OK but I'd like to hear from Rafael as he wrote the code you are updating.
================
Comment at: ELF/LinkerScript.cpp:758
+ OutputSection *Sec = Cmd->Sec;
+ // Only propagate program headers to sections that are allocated.
+ if (Sec && (Sec->Flags & SHF_ALLOC))
----------------
Describe not what this code does but why you want it.
================
Comment at: ELF/LinkerScript.cpp:761-762
+ Cmd->Phdrs = DefPhdrs;
+ }
+ else {
DefPhdrs = Cmd->Phdrs;
----------------
Please format according to the LLVM coding style.
https://reviews.llvm.org/D34204
More information about the llvm-commits
mailing list