[PATCH] D34554: [ELF] FIx use-after-return of archive path

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 23 08:21:10 PDT 2017


ruiu added a comment.

I think a better approach would be to change the type of `ArchiveName` from StringRef to std::string. This patch may fix the issue, but I'm not 100% sure because it fixes only one path that can reach `addFile` function. There might be some other places at which we pass on-stack objects to the function.


Repository:
  rL LLVM

https://reviews.llvm.org/D34554





More information about the llvm-commits mailing list