[PATCH] D32272: [XRay] Add Google Benchmark library + initial XRay benchmarks

Dean Michael Berris via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 23 05:48:22 PDT 2017


dberris accepted this revision.
dberris added a comment.

LGTM for the most part, thanks for making the changes, it's much simpler now.

Thoughts @MatzeB? I think we can work on running/reporting the microbenchmarks data later, in changes to LNT.



================
Comment at: CMakeLists.txt:187
     get_filename_component(subdir ${entry} DIRECTORY)
-    # Exclude tools and CTMark from default list
+    # Exclude tools, libs, and CTMark from default list
     if(NOT ${subdir} STREQUAL ${CMAKE_CURRENT_SOURCE_DIR}/tools AND
----------------
Also the MicroBenchmarks ?


https://reviews.llvm.org/D32272





More information about the llvm-commits mailing list