[PATCH] D34362: [LNT] Support for different DataSet usage in Polybench for "lnt runtest nt"

[Kristof Beyls via Phabricator via llvm-commits]

kristof.beyls added reviewers: MatzeB, cmatthews.
kristof.beyls added a comment.

In https://reviews.llvm.org/D34362#788285, @Meinersbur wrote:

> I think `nt.py` is deprecated, and meant to be replaced by `test_suite.py`.
>
> Maybe someone who already contributed to lnt should be necessary for acceptance.


A few of the most active developers on test-suite and lnt at least think it's better to use the (new) CMake+lit-based system to drive the test-suite rather than the (old) Makefile-based system. 'nt.py' in LNT is a layer around the Makefile-based system, "test_suite.py" is a layer around the CMake+lit-based system. I guess you could say that makes nt.py "deprecated".

Anyway, on the patch itself here: I don't really like adding ever more separate command line options for specifying different data sizes available in a test suite. Wouldn't it be better to introduce a command line argument spelled e.g. "--datasize=mini|small|standard|large|extra_large"? We could then also hopefully deprecate "--small", "--large", "--spec-with-ref", etc., making them aliases for the new command line option for backwards compatibility. Note that I haven't thought about what the best name would be for this option. Maybe "inputsize" is more in line with common terminology across benchmarks? Although it may be hard to guess from the "inputsize" exactly what it means without further explanation either...

Also, please in the future upload diffs with more context, see http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface.


Repository:
  rL LLVM

https://reviews.llvm.org/D34362