[PATCH] D34278: [InstCombine] Recognize and simplify three way comparison idioms

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev accepted this revision.
mkazantsev added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: lib/Transforms/InstCombine/InstCombineCompares.cpp:2441
+                                           ConstantInt *&Greater) {
+
+  // TODO: Generalize this to work with other comparison idioms or ensure
----------------
Why do we need this blank line?


================
Comment at: lib/Transforms/InstCombine/InstCombineCompares.cpp:2507
+  return nullptr;
+
+}
----------------
Same here.


https://reviews.llvm.org/D34278