[PATCH] D34545: [AMDGPU] Simplify setcc (sext from i1 b), -1|0, cc

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: lib/Target/AMDGPU/SIISelLowering.cpp:5143
+    if ((CRHS->isAllOnesValue() &&
+         (CC == ISD::SETNE || CC == ISD::SETGT || CC == ISD::SETULT)) ||
+        (CRHS->isNullValue() &&
----------------
arsenm wrote:
> I don't think it is useful check the GT/LT cases. I would expect those to fold to eq/ne the bool value already
It is not folded. At least not always.


https://reviews.llvm.org/D34545