[PATCH] D34544: [libunwind] Don't assume the return address register is always saved and has CFI for it

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 22 17:44:49 PDT 2017


hfinkel added inline comments.


================
Comment at: src/DwarfInstructions.hpp:168
       R newRegisters = registers;
-      pint_t returnAddress = 0;
+      // assume the return address is in the return address register, first,
+      // then if we find CFI for it, we get it from there. this allows
----------------
Please start sentences in comments with a capital letter.


https://reviews.llvm.org/D34544





More information about the llvm-commits mailing list